mirror of
https://github.com/lucide-icons/lucide.git
synced 2026-11-12 13:38:32 +00:00
4b3f93d9d0
* Updates needed to support Solid 2 * Switch to the next tag * feat(packages): add `@lucide/solid` package for Solid 2 Solid 2's API is a breaking change from Solid 1 and is still an RC, so `lucide-solid` stays on Solid 1 (`solid-js: ^1.4.7`) untouched and Solid 2 support ships as a new `packages/solid` package named `@lucide/solid` — the same scheme already used by `@lucide/svelte` and `@lucide/angular`. The package is a copy of `lucide-solid` on the `@lucide/shared` build architecture, ported to Solid 2: - `splitProps` -> `omit`, `solid-js/web` -> `@solidjs/web`, `JSXElement` -> `Element`, `Context.Provider` -> `<Context value>` - `jsxImportSource` is `@solidjs/web` in tsconfig, the esbuild step and `ts.createProgram`; rollup externals drop the removed `solid-js/store` - `vite-plugin-solid` -> `@solidjs/vite-plugin` - tests keep upstream's coverage with two Solid 2 adaptations: boolean attribute literals must be strings (`aria-hidden="false"`), and writes are batched so the reactivity tests need a `flush()` before asserting Rendered output is unchanged — the snapshots are byte-identical to `lucide-solid`'s. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(solid): fix React leftovers in the Solid guide The Solid guide was derived from the React guide and three things were not carried across: - `advanced/typescript.md` still told readers the types are for "a TypeScript React project" - its `LucideIcon` example kept React's destructured-props signature. The `: ButtonProps` annotation had also been dropped in the copy, so `ButtonProps` was declared but unused and the parameters were implicitly `any`. Destructuring props breaks reactivity in Solid — verified: with `({ icon: Icon, label })` a changing `label` never reaches the DOM, while `props.label` updates correctly. - `advanced/aliased-names.md` had an orphaned `###` heading; its parent `## Choosing import name style` was dropped during the conversion because it documents React-only subpath exports. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: type the shared Sandpack wrapper with `SandpackProps` The base Sandpack wrapper declared its props as `FunctionalComponent<LucideProps>` with `LucideProps` imported from `@lucide/vue`, which has nothing to do with a Sandpack embed. None of the props the markdown plugin actually passes (`template`, `files`, `options`, `customSetup`, `theme`) were declared, so they only reached the inner `<Sandpack />` via Vue's fallthrough attributes. Declare `SandpackProps` from `sandpack-vue3` instead and forward them explicitly. This also removes the `@lucide/vue` import that made every framework guide — including the Solid one, which uses this wrapper directly — appear to reference the Vue package. Verified with a full `vitepress build`: each framework guide's chunk still carries its own template (react/vue/vite-svelte/vanilla/ vite-solid) and all five props reach the component. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(solid): document the Solid 2 flavour in the getting started guide The Solid guide teaches `lucide-solid` throughout (64 references), so the one-line note about `@lucide/solid` left Solid 2 readers on a page whose every install command and live example is Solid 1 — and the packages list points `@lucide/solid` at this same page. Replace that note with a "Using Solid 2?" callout holding its own tabbed install group, the import-specifier swap, and a table of the Solid 2 changes that affect code written around Lucide (`@solidjs/web`, `jsxImportSource`, `splitProps` -> `omit`, `<Ctx value>`), linking out to Solid's own migration guide for the rest. The claim that both packages expose the same components and props is checked, not assumed: `dist/types/lucide-solid.d.ts` is identical between the two packages, and the only differences anywhere in the public type surface are Solid's own renames (the `JSX` namespace source and `JSXElement` -> `Element`). Keeps one guide section for both packages, matching how upstream handles the two Svelte packages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat(solid): port lucide-solid to Solid 2 - Icon/context/types use Solid 2 APIs: omit() instead of splitProps(), Dynamic and JSX types from @solidjs/web. - solid-js / @solidjs/web 2.0 (rc) as peer and dev dependencies, babel-preset-solid 2; rollup and tsconfig updated to match. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Add integration test * Update rollup file * Fix tests * Revert lucide-solid changes * update lockfile * Fix docs * Format code --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Eric <eric.fennis@gmail.com>
96 lines
4.6 KiB
JSON
96 lines
4.6 KiB
JSON
{
|
|
"private": true,
|
|
"type": "module",
|
|
"scripts": {
|
|
"build": "pnpm -r --filter './packages/**' build",
|
|
"test": "pnpm -r --filter './packages/**' test",
|
|
"test:update": "pnpm -r --filter './packages/**' --filter !'./packages/lucide-angular' test -- -u",
|
|
"test:integrations:react": "pnpm --filter lucide-react build && pnpm -r --workspace-concurrency=1 --filter './integrations/lucide-react/**' check",
|
|
"test:integrations:solid": "pnpm --filter lucide-solid build && pnpm -r --workspace-concurrency=1 --filter './integrations/lucide-solid/**' check",
|
|
"test:integrations:solid-2": "pnpm --filter @lucide/solid build && pnpm -r --workspace-concurrency=1 --filter './integrations/lucide-solid-2/**' check",
|
|
"test:integrations:vue": "pnpm --filter @lucide/vue build && pnpm -r --workspace-concurrency=1 --filter './integrations/lucide-vue/**' check",
|
|
"test:font": "pnpm --filter build-font test",
|
|
"lucide": "pnpm --filter lucide",
|
|
"lucide-angular": "pnpm --filter lucide-angular",
|
|
"lucide-react": "pnpm --filter lucide-react",
|
|
"lucide-react-native": "pnpm --filter lucide-react-native",
|
|
"lucide-preact": "pnpm --filter lucide-preact",
|
|
"lucide-solid": "pnpm --filter lucide-solid",
|
|
"lucide-vue": "pnpm --filter lucide-vue",
|
|
"lucide-astro": "pnpm --filter @lucide/astro",
|
|
"lucide-vue-next": "pnpm --filter lucide-vue-next",
|
|
"lucide-svelte": "pnpm --filter lucide-svelte",
|
|
"lucide-static": "pnpm --filter lucide-static",
|
|
"build:outline-icons": "pnpm --filter outline-svg start",
|
|
"build:font": "pnpm --filter build-font start",
|
|
"optimize": "node ./scripts/optimizeSvgs.mts",
|
|
"addjsons": "node ./scripts/addMissingIconJsonFiles.mts",
|
|
"checkIcons": "node ./scripts/checkIconsAndCategories.mts",
|
|
"checkLabIcons": "node ./scripts/checkLabIcons.mts",
|
|
"generate:sponsors": "node scripts/updateSponsors.mts",
|
|
"generate:contributors": "node ./scripts/updateContributors.mts icons/*.svg",
|
|
"generate:nextJSAliases": "node ./scripts/generateNextJSAliases.mts",
|
|
"suggest:metadata": "node ./scripts/suggestMetaData.mts",
|
|
"suggest:metadata:debug": "node --env-file .env ./scripts/suggestMetaData.mts --debug",
|
|
"suggest:metadata:watch": "node --env-file .env --watch ./scripts/suggestMetaData.mts",
|
|
"postinstall": "husky",
|
|
"lint:es": "eslint .",
|
|
"lint:format": "prettier \"**/*.{js,mjs,ts,jsx,tsx,html,css,scss,json,yml,yaml}\" --check",
|
|
"lint:format-fix": "prettier \"**/*.{js,mjs,ts,jsx,tsx,html,css,scss,json,yml,yaml}\" --write",
|
|
"lint:icons": "prettier \"icons/*.svg\" --check",
|
|
"lint:icons-fix": "prettier \"icons/*.svg\" --write",
|
|
"lint:json:icons": "ajv --spec=draft2020 -s icon.schema.json -d 'icons/*.json' > /dev/null",
|
|
"lint:json:categories": "ajv --spec=draft2020 -s category.schema.json -d 'categories/*.json' > /dev/null",
|
|
"lint:json": "pnpm run lint:json:icons && pnpm run lint:json:categories",
|
|
"lint:icons:all": "pnpm run lint:icons && pnpm run lint:json:icons",
|
|
"lint": "pnpm lint:es && pnpm lint:format && pnpm lint:json && pnpm lint:icons",
|
|
"format": "prettier \"**/*.{js,mjs,ts,jsx,tsx,html,css,scss,json,yml,yaml}\" --write",
|
|
"prepare": "husky",
|
|
"gi": "node ./scripts/generate/generateIcons.mts",
|
|
"rename": "node ./scripts/rename/renameIcon.mts",
|
|
"renamePattern": "node ./scripts/rename/renamePattern.mts"
|
|
},
|
|
"devDependencies": {
|
|
"@actions/core": "^3.0.1",
|
|
"@actions/github": "^9.1.1",
|
|
"@eslint/compat": "^2.1.0",
|
|
"@eslint/js": "^10.0.1",
|
|
"@html-eslint/eslint-plugin": "^0.65.0",
|
|
"@html-eslint/parser": "^0.65.0",
|
|
"@octokit/rest": "^22.0.1",
|
|
"@types/yargs": "^17.0.35",
|
|
"@typescript-eslint/eslint-plugin": "^8.69.0",
|
|
"@typescript-eslint/parser": "^8.69.0",
|
|
"@vitest/coverage-v8": "5.0.3",
|
|
"@vitest/ui": "5.0.3",
|
|
"ajv-cli": "^5.0.0",
|
|
"cpy-cli": "^7.0.0",
|
|
"cspell": "^10.2.0",
|
|
"dotenv": "^17.4.2",
|
|
"eslint": "^10.9.1",
|
|
"eslint-config-prettier": "^10.1.8",
|
|
"eslint-plugin-import-x": "^4.17.1",
|
|
"husky": "^9.1.7",
|
|
"jsdom": "^30.0.1",
|
|
"lint-staged": "^17.4.1",
|
|
"minimist": "^1.2.8",
|
|
"openai": "^7.9.0",
|
|
"p-memoize": "^8.0.0",
|
|
"prettier": "3.9.6",
|
|
"prettier-plugin-astro": "^0.14.1",
|
|
"semver": "^7.8.5",
|
|
"simple-git": "^3.36.0",
|
|
"svgo": "^4.1.0",
|
|
"svgson": "^5.3.1",
|
|
"typescript": "^6.0.3",
|
|
"typescript-eslint": "^8.69.0",
|
|
"vitest": "5.0.3",
|
|
"yargs": "^18.1.0",
|
|
"zod": "^4.5.4"
|
|
},
|
|
"engines": {
|
|
"node": ">=24.11.1"
|
|
},
|
|
"packageManager": "pnpm@11.22.0+sha512.1ff870c4c6133dfd88fb2afc46dd13d47f09c9794b438c6fdb47ca98caf3bc16381ee0be93a091b8e3824cf01f889f46d7d9e20910fb0be1ab0fb5baa80dd621"
|
|
}
|