mirror of
https://github.com/lucide-icons/lucide.git
synced 2026-11-17 14:28:25 +00:00
Fix inheriting attrs (#488)
This commit is contained in:
@@ -71,6 +71,7 @@ export default (element, { nameAttr, icons, attrs }) => {
|
||||
...iconAttributes,
|
||||
'icon-name': iconName,
|
||||
...attrs,
|
||||
...elementAttrs,
|
||||
};
|
||||
|
||||
const classNames = combineClassNames(['lucide', `lucide-${iconName}`, elementAttrs, attrs]);
|
||||
|
||||
@@ -64,4 +64,25 @@ describe('createIcons', () => {
|
||||
|
||||
expect(attributesAndValues).toEqual(expect.objectContaining(attrs));
|
||||
});
|
||||
|
||||
it('should inherit elements attributes', () => {
|
||||
document.body.innerHTML = `<i icon-name="sun" data-theme-switcher="light"></i>`;
|
||||
|
||||
const attrs = {
|
||||
'data-theme-switcher':'light',
|
||||
};
|
||||
|
||||
createIcons({ icons });
|
||||
|
||||
const element = document.querySelector('svg');
|
||||
const attributes = element.getAttributeNames();
|
||||
|
||||
const attributesAndValues = attributes.reduce((acc, item) => {
|
||||
acc[item] = element.getAttribute(item);
|
||||
|
||||
return acc;
|
||||
},{})
|
||||
|
||||
expect(attributesAndValues).toEqual(expect.objectContaining(attrs));
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user