Fix inheriting attrs (#488)

This commit is contained in:
Eric Fennis
2022-01-31 17:15:20 +01:00
committed by GitHub
parent 9cecb243ff
commit c9524f205a
2 changed files with 22 additions and 0 deletions
+1
View File
@@ -71,6 +71,7 @@ export default (element, { nameAttr, icons, attrs }) => {
...iconAttributes,
'icon-name': iconName,
...attrs,
...elementAttrs,
};
const classNames = combineClassNames(['lucide', `lucide-${iconName}`, elementAttrs, attrs]);
+21
View File
@@ -64,4 +64,25 @@ describe('createIcons', () => {
expect(attributesAndValues).toEqual(expect.objectContaining(attrs));
});
it('should inherit elements attributes', () => {
document.body.innerHTML = `<i icon-name="sun" data-theme-switcher="light"></i>`;
const attrs = {
'data-theme-switcher':'light',
};
createIcons({ icons });
const element = document.querySelector('svg');
const attributes = element.getAttributeNames();
const attributesAndValues = attributes.reduce((acc, item) => {
acc[item] = element.getAttribute(item);
return acc;
},{})
expect(attributesAndValues).toEqual(expect.objectContaining(attrs));
});
});