fix(shared): Add trim to mergeClasses (#2522)

* Add trim to merge classes

* Add trim to merge classes

* Adds extra utils check

* Update packages/shared/src/utils.ts

Co-authored-by: Max Malm <benjick@dumfan.net>

---------

Co-authored-by: Max Malm <benjick@dumfan.net>

.github/workflows/lucide-preact.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - packages/lucide-preact/**
+      - packages/shared/**
       - tools/build-icons/**
       - tools/rollup-plugins/**
       - pnpm-lock.yaml

.github/workflows/lucide-react-native.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - packages/lucide-react-native/**
+      - packages/shared/**
       - tools/build-icons/**
       - tools/rollup-plugins/**
       - pnpm-lock.yaml

.github/workflows/lucide-react.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - packages/lucide-react/**
+      - packages/shared/**
       - tools/build-icons/**
       - tools/rollup-plugins/**
       - scripts/generateNextJSAliases.mjs

.github/workflows/lucide-shared.yml

@@ -0,0 +1,24 @@
+name: Lucide Shared Checks
+
+on:
+  pull_request:
+    paths:
+      - packages/shared/**
+      - pnpm-lock.yaml
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
+      - uses: actions/setup-node@v3.8.1
+        with:
+          node-version: 18
+          cache: 'pnpm'
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Test
+        run: pnpm --filter lucide-react test

.github/workflows/lucide-solid.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - packages/lucide-solid/**
+      - packages/shared/**
       - tools/build-icons/**
       - tools/rollup-plugins/**
       - pnpm-lock.yaml

.github/workflows/lucide-svelte.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - packages/lucide-svelte/**
+      - packages/shared/**
       - tools/build-icons/**
       - tools/rollup-plugins/**
       - pnpm-lock.yaml

.github/workflows/lucide-vue-next.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - packages/lucide-vue-next/**
+      - packages/shared/**
       - tools/build-icons/**
       - tools/rollup-plugins/**
       - pnpm-lock.yaml

.github/workflows/lucide-vue.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - packages/lucide-vue/**
+      - packages/shared/**
       - tools/build-icons/**
       - tools/rollup-plugins/**
       - pnpm-lock.yaml

packages/shared/src/utils.ts

@@ -41,6 +41,11 @@ export const toPascalCase = <T extends string>(string: T): CamelToPascal<T> => {
 export const mergeClasses = <ClassType = string | undefined | null>(...classes: ClassType[]) =>
   classes
     .filter((className, index, array) => {
-      return Boolean(className) && array.indexOf(className) === index;
+      return (
+        Boolean(className) &&
+        (className as string).trim() !== '' &&
+        array.indexOf(className) === index
+      );
     })
-    .join(' ');
+    .join(' ')
+    .trim();

packages/shared/tests/utils.spec.tsx

@@ -18,4 +18,12 @@ describe('mergeClasses', () => {
     const classes = mergeClasses('lucide', 'lucide-circle', 'lucide');
     expect(classes).toBe('lucide lucide-circle');
   });
+  it('trims the string', async () => {
+    const classes = mergeClasses('lucide', 'lucide-circle', ' ');
+    expect(classes).toBe('lucide lucide-circle');
+  });
+  it('trims the sub strings', async () => {
+    const classes = mergeClasses('lucide', ' ', 'lucide-circle');
+    expect(classes).toBe('lucide lucide-circle');
+  });
 });