mirror of
https://github.com/lucide-icons/lucide.git
synced 2026-11-13 13:48:26 +00:00
e042fec3b5
`lucide-react` and `lucide-react-native` both ship `.d.ts` files that import React types (`ForwardRefExoticComponent`, `SVGProps`, `RefAttributes`, `ReactNode`), but neither package declares `@types/react`. Under a hoisted `node_modules` this resolves by accident, so the gap is invisible in normal testing. It does not resolve under a strict layout — most notably pnpm's global virtual store (`enableGlobalVirtualStore`), where each package is linked from a store path outside the consuming repo. TypeScript resolves a package's imports relative to where that package physically lives and ignores `NODE_PATH`, so `react` resolves to the untyped `react/index.js`. Every icon's props silently degrade to `any`, and consumers hit implicit-any errors on their own callbacks under `noImplicitAny`. `skipLibCheck: true` hides the errors inside the `.d.ts` itself, which is why this survives most typechecks. Declaring the typings package as a peer dependency (rather than a hard dependency) lets it dedupe against whatever `@types/react` the consumer already has. `peerDependenciesMeta` marks it optional so JS-only consumers get no unmet-peer warning. Verified by packing each package and installing the tarball into a scratch consumer with `pnpm --virtual-store-dir` pointing outside the consumer, then typechecking with `skipLibCheck: false` and a `@ts-expect-error` probe on a nonexistent icon prop — a positive type assertion keeps passing when types widen to `any`, so it would not catch a regression. Before the change the probe reports `TS2578: Unused '@ts-expect-error' directive` plus `TS7016` inside the shipped `.d.ts`; after it, `tsc` is clean and `--traceResolution` shows `react` resolving to `@types/react/index.d.ts` instead of `react/index.js`. Existing peer ranges are unchanged and the lockfile is unaffected. Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Eric Fennis <eric.fennis@gmail.com>
80 lines
2.5 KiB
JSON
80 lines
2.5 KiB
JSON
{
|
|
"name": "lucide-react",
|
|
"description": "A Lucide icon library package for React applications.",
|
|
"version": "0.0.1",
|
|
"license": "ISC",
|
|
"homepage": "https://lucide.dev",
|
|
"bugs": "https://github.com/lucide-icons/lucide/issues",
|
|
"repository": {
|
|
"type": "git",
|
|
"url": "https://github.com/lucide-icons/lucide.git",
|
|
"directory": "packages/lucide-react"
|
|
},
|
|
"keywords": [
|
|
"Lucide",
|
|
"React",
|
|
"Feather",
|
|
"Icons",
|
|
"Icon",
|
|
"SVG",
|
|
"Feather Icons",
|
|
"Fontawesome",
|
|
"Font Awesome"
|
|
],
|
|
"author": "Eric Fennis",
|
|
"amdName": "lucide-react",
|
|
"main": "dist/cjs/lucide-react.js",
|
|
"module": "dist/esm/lucide-react.mjs",
|
|
"typings": "dist/lucide-react.d.ts",
|
|
"sideEffects": false,
|
|
"files": [
|
|
"dist",
|
|
"dynamic.js",
|
|
"dynamic.mjs",
|
|
"dynamic.mjs.map",
|
|
"dynamic.d.mts",
|
|
"dynamic.d.ts",
|
|
"dynamicIconImports.mjs",
|
|
"dynamicIconImports.d.ts",
|
|
"dynamicIconImports.d.mts"
|
|
],
|
|
"scripts": {
|
|
"build": "pnpm clean && pnpm copy:license && pnpm build:icons && pnpm typecheck && pnpm build:bundles",
|
|
"copy:license": "cp ../../LICENSE ./LICENSE",
|
|
"clean": "rm -rf dist && rm -rf stats && rm -rf ./src/icons/*.ts && rm -f dynamic.{d.ts,d.mts,mts,mjs,mjs.map} && rm -f dynamicIconImports.d.ts",
|
|
"build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mts --renderUniqueKey --withAliases --withDynamicImports --separateAliasesFile --separateAliasesFileIgnore=fingerprint --aliasesFileExtension=.ts --iconFileExtension=.ts --exportFileName=index.ts",
|
|
"build:bundles": "rollup -c ./rollup.config.mjs",
|
|
"typecheck": "pnpm build:icons && tsc --noEmit",
|
|
"typecheck:watch": "tsc -w",
|
|
"test": "pnpm build:icons && vitest run",
|
|
"test:watch": "vitest watch"
|
|
},
|
|
"devDependencies": {
|
|
"@lucide/build-icons": "workspace:*",
|
|
"@lucide/rollup-plugins": "workspace:*",
|
|
"@lucide/shared": "workspace:*",
|
|
"@testing-library/jest-dom": "^7.0.1",
|
|
"@testing-library/react": "^16.3.3",
|
|
"@types/node": "^25.9.1",
|
|
"@types/react": "^18.3.31",
|
|
"@vitejs/plugin-react": "^5.2.0",
|
|
"jest-serializer-html": "^7.1.0",
|
|
"react": "18.3.1",
|
|
"react-dom": "18.3.1",
|
|
"rollup": "^4.63.1",
|
|
"rollup-plugin-dts": "^6.5.1",
|
|
"rollup-plugin-preserve-directives": "^0.4.0",
|
|
"typescript": "^6.0.3",
|
|
"vite": "^7.3.6"
|
|
},
|
|
"peerDependencies": {
|
|
"@types/react": "*",
|
|
"react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0"
|
|
},
|
|
"peerDependenciesMeta": {
|
|
"@types/react": {
|
|
"optional": true
|
|
}
|
|
}
|
|
}
|