mirror of
https://github.com/lucide-icons/lucide.git
synced 2026-11-14 13:58:21 +00:00
Saadanjum0andKarsa
e8a2c60b75
* fix(shared): escape attribute values in buildLucideSvg Attribute values were interpolated into the SVG string as-is, so a value containing a double quote, ampersand or angle bracket (for example in a custom attribute or class name) produced malformed markup. * Use replace(/x/g) instead of replaceAll for broader TS lib compat lucide-react-native's tsconfig doesn't include the ES2021 lib that replaceAll requires, failing typecheck. A global regex replace is functionally identical here and works under any target. * Escape the full set of relevant HTML entities in attribute values Also escape > and ' per review feedback, not just & " <. * Apply suggestion from @karsa-mistmere --------- Co-authored-by: Karsa <contact@karsa.org>
15 lines
520 B
TypeScript
15 lines
520 B
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import buildLucideSvg from '../src/build/buildLucideSvg';
|
|
|
|
const icon = { name: 'dot', size: 24, node: [['circle', { cx: 12, cy: 12, r: 1 }]] } as const;
|
|
|
|
describe('buildLucideSvg', () => {
|
|
it('should escape special characters in attribute values', () => {
|
|
const svg = buildLucideSvg(icon as any, {
|
|
attributes: { 'data-label': 'a\'s "quoted" <b> & c' },
|
|
});
|
|
|
|
expect(svg).toContain('data-label="a's "quoted" <b> & c"');
|
|
});
|
|
});
|