mirror of
https://github.com/lucide-icons/lucide.git
synced 2026-11-10 13:18:25 +00:00
* ci: split lint-code into ESLint, Prettier and JSON Schema jobs with PR annotations - ESLint: annotations via setup-node's built-in eslint-stylish problem matcher. - Prettier: new scripts/lintFormat.mts formats unformatted files in memory, diffs them and emits line-level `::error` annotations with the expected code. - JSON Schema: replace ajv-cli with a local ESLint rule (Ajv draft 2020-12) that validates icons/categories JSON against their `$schema` and reports at the offending property. eslint-plugin-json-schema-validator was not used because it runs Ajv in draft-07 mode and ignores `dependentRequired`. All annotations use workflow commands, so they work on fork PRs with a read-only token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FVxEtqNswEDq1N23taZYh8 * Improve root value check and property error handling Enhance error reporting for JSON schema validation. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * style(lint): format jsonSchemaPlugin with Prettier Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FVxEtqNswEDq1N23taZYh8 * test commit * fix(lint): annotate syntax errors from Prettier and ESLint in PRs - ESLint/JSON Schema jobs use a small GitHub formatter that prints `::error` workflow commands. setup-node's eslint-stylish matcher skipped parsing errors because they have no rule id. - lintFormat.mts annotates Prettier syntax errors (exit code 2) at their line and column instead of only printing stderr, and still checks the other files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FVxEtqNswEDq1N23taZYh8 * ci(lint): spell check icon and category metadata with cspell annotations - New "Spelling" job runs scripts/lintSpelling.mts, which turns cspell findings into `::error` annotations (with cspell's suggested fix when it has one). - cspell accepts both US and British English, ignores contributor usernames and deprecated `alias.typo` aliases. - Add existing search tags and domain terms to .cspell/custom-words.txt so the current metadata passes. - Add `lint:spelling` to `pnpm lint` and lint-staged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FVxEtqNswEDq1N23taZYh8 * fix(lint): pin JSON schemas per file set and drop typo tags - json-schema/no-invalid now takes the schema from config (icon.schema.json for icons, category.schema.json for categories) and reports a `$schema` that points elsewhere, so metadata can't opt out of validation. - Remove the misspelled `frigerator` and `sterisk` tags and their allowlist entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FVxEtqNswEDq1N23taZYh8 * fix(icons): split joined-word tags into separate words Tags like `groupchat` and `timemachine` become `group chat` and `time machine` so they read naturally and pass the spell check without allowlisting. Where the spaced tag already existed (`smart home`) the joined one is dropped. cspell now skips all alias names, since they are icon names that can't change (e.g. the deprecated `palmtree` alias). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FVxEtqNswEDq1N23taZYh8 * Revert * Try another error * Revert error --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
179 lines
5.2 KiB
JavaScript
179 lines
5.2 KiB
JavaScript
import path from 'node:path';
|
|
import js from '@eslint/js';
|
|
import { includeIgnoreFile } from '@eslint/compat';
|
|
import { defineConfig } from 'eslint/config';
|
|
import prettier from 'eslint-config-prettier';
|
|
import importX, { createNodeResolver } from 'eslint-plugin-import-x';
|
|
import htmlEslint from '@html-eslint/eslint-plugin';
|
|
import htmlParser from '@html-eslint/parser';
|
|
import defaultAttrs from './tools/build-icons/render/default-attrs.json' with { type: 'json' };
|
|
import tseslint from 'typescript-eslint';
|
|
import jsonSchema from './scripts/eslint/jsonSchemaPlugin.mjs';
|
|
import * as jsoncParser from 'jsonc-eslint-parser';
|
|
|
|
const gitignorePath = path.join(import.meta.dirname, '.gitignore');
|
|
|
|
export default defineConfig([
|
|
tseslint.configs.recommended,
|
|
{
|
|
// `packages/angular` has its own config with its own tsconfig, so a single `eslint .` run sees
|
|
// two candidate roots and typescript-eslint refuses to guess between them.
|
|
languageOptions: {
|
|
parserOptions: {
|
|
tsconfigRootDir: import.meta.dirname,
|
|
},
|
|
},
|
|
},
|
|
// Everything git ignores (generated icon sources, build output, caches) is ignored here too.
|
|
includeIgnoreFile(gitignorePath),
|
|
{
|
|
// Ignores that are not in .gitignore, because these files are committed.
|
|
ignores: [
|
|
'lib',
|
|
'**/tests',
|
|
'packages/**/tests/*',
|
|
'docs/images',
|
|
'docs/**/examples/',
|
|
'docs/.vitepress/theme/components/editors/preact/index.js',
|
|
'packages/svelte/.svelte-kit',
|
|
'integrations/**/file-routes.d.ts',
|
|
// Tracked in git despite matching a .gitignore pattern, so lint it.
|
|
'!packages/lucide-react/dynamicIconImports.mjs',
|
|
],
|
|
},
|
|
{
|
|
files: ['**/*.js'],
|
|
languageOptions: {
|
|
ecmaVersion: 'latest',
|
|
sourceType: 'module',
|
|
globals: {
|
|
console: 'readonly',
|
|
process: 'readonly',
|
|
global: 'readonly',
|
|
__dirname: 'readonly',
|
|
},
|
|
},
|
|
plugins: {
|
|
'import-x': importX,
|
|
},
|
|
settings: {
|
|
'import-x/resolver-next': [createNodeResolver()],
|
|
},
|
|
rules: {
|
|
...js.configs.recommended.rules,
|
|
...prettier.rules,
|
|
'no-console': 'off',
|
|
'no-param-reassign': 'off',
|
|
'no-shadow': 'off',
|
|
'no-use-before-define': 'off',
|
|
'import-x/no-extraneous-dependencies': [
|
|
'error',
|
|
{
|
|
devDependencies: [
|
|
'**/*.test.js',
|
|
'**/*.spec.js',
|
|
'**/scripts/**',
|
|
'eslint.config.js',
|
|
'packages/**/tests/**',
|
|
],
|
|
},
|
|
],
|
|
'import-x/extensions': [
|
|
'error',
|
|
{
|
|
pattern: {
|
|
mjs: 'always',
|
|
json: 'always',
|
|
},
|
|
},
|
|
],
|
|
},
|
|
},
|
|
{
|
|
rules: {
|
|
// Omitting a property by destructuring it away (`const { key, ...attrs } = node`) leaves the
|
|
// omitted binding unused on purpose, so don't report it.
|
|
'@typescript-eslint/no-unused-vars': ['error', { ignoreRestSiblings: true }],
|
|
},
|
|
},
|
|
{
|
|
files: ['./icons/*.svg'],
|
|
languageOptions: {
|
|
parser: htmlParser,
|
|
},
|
|
plugins: {
|
|
'@html-eslint': htmlEslint,
|
|
},
|
|
rules: {
|
|
'@html-eslint/require-doctype': 'off',
|
|
'@html-eslint/no-duplicate-attrs': 'error',
|
|
'@html-eslint/no-inline-styles': 'error',
|
|
'@html-eslint/require-attrs': [
|
|
'error',
|
|
...Object.entries(defaultAttrs).map(([attr, value]) => ({
|
|
tag: 'svg',
|
|
attr,
|
|
value: String(value),
|
|
})),
|
|
],
|
|
'@html-eslint/indent': ['error', 2],
|
|
'@html-eslint/no-multiple-empty-lines': ['error', { max: 0 }],
|
|
'@html-eslint/no-extra-spacing-attrs': [
|
|
'error',
|
|
{
|
|
enforceBeforeSelfClose: true,
|
|
},
|
|
],
|
|
'@html-eslint/attrs-newline': [
|
|
'error',
|
|
{
|
|
inline: ['path', 'line', 'polyline', 'polygon', 'rect', 'circle', 'ellipse'],
|
|
},
|
|
],
|
|
'@html-eslint/require-closing-tags': [
|
|
'error',
|
|
{
|
|
selfClosing: 'always',
|
|
// Inside <svg> every tag counts as "foreign", where the rule only checks that a tag
|
|
// already written `/>` stays that way. Listing the shapes here is what actually forces
|
|
// `<path ...></path>` to become `<path ... />`.
|
|
selfClosingCustomPatterns: ['^(path|line|polyline|polygon|rect|circle|ellipse)$'],
|
|
},
|
|
],
|
|
'@html-eslint/no-restricted-attr-values': [
|
|
'error',
|
|
{
|
|
attrPatterns: ['^(fill|stroke)$'],
|
|
attrValuePatterns: ['^(?!(none|currentColor)$).*$'],
|
|
message:
|
|
'Icons must inherit their colors: `fill` and `stroke` may only be `none` or `currentColor`.',
|
|
},
|
|
],
|
|
'@html-eslint/element-newline': 'error',
|
|
'@html-eslint/no-trailing-spaces': 'error',
|
|
'@html-eslint/quotes': 'error',
|
|
},
|
|
},
|
|
{
|
|
files: ['icons/*.json', 'categories/*.json'],
|
|
languageOptions: {
|
|
parser: jsoncParser,
|
|
},
|
|
plugins: {
|
|
'json-schema': jsonSchema,
|
|
},
|
|
},
|
|
{
|
|
files: ['icons/*.json'],
|
|
rules: {
|
|
'json-schema/no-invalid': ['error', { schema: 'icon.schema.json' }],
|
|
},
|
|
},
|
|
{
|
|
files: ['categories/*.json'],
|
|
rules: {
|
|
'json-schema/no-invalid': ['error', { schema: 'category.schema.json' }],
|
|
},
|
|
},
|
|
]);
|