From e732f4dd6d094ddf34b51436b61be0033993c6a7 Mon Sep 17 00:00:00 2001 From: Eric Fennis Date: Sat, 18 Jul 2020 01:14:30 +0200 Subject: [PATCH] Refactor names --- scripts/build/generateIconFiles.js | 6 +++--- scripts/buildIcons.js | 4 ++-- scripts/render/{renderIconVNodes.js => renderIconNodes.js} | 6 +++--- src/getters/getElement.js | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) rename scripts/render/{renderIconVNodes.js => renderIconNodes.js} (87%) diff --git a/scripts/build/generateIconFiles.js b/scripts/build/generateIconFiles.js index 04915c5ce..83b41ed7d 100644 --- a/scripts/build/generateIconFiles.js +++ b/scripts/build/generateIconFiles.js @@ -3,9 +3,9 @@ import path from 'path'; import prettier from 'prettier'; import { generateComponentName } from './helpers'; -export default function(iconVNodesObject, outputDirectory) { +export default function(iconNode, outputDirectory) { - const icons = Object.keys(iconVNodesObject); + const icons = Object.keys(iconNode); const iconsDistDirectory = path.join(outputDirectory, `icons`); if (!fs.existsSync(iconsDistDirectory)){ @@ -16,7 +16,7 @@ export default function(iconVNodesObject, outputDirectory) { const location = path.join(iconsDistDirectory, `${icon}.js`); const ComponentName = generateComponentName(icon); - const VNode = JSON.stringify(iconVNodesObject[icon]); + const VNode = JSON.stringify(iconNode[icon]); const element = ` export default [${VNode}] diff --git a/scripts/buildIcons.js b/scripts/buildIcons.js index 26557b717..732384f04 100644 --- a/scripts/buildIcons.js +++ b/scripts/buildIcons.js @@ -2,7 +2,7 @@ import fs from 'fs'; import path from 'path'; import renderIconsObject from './render/renderIconsObject'; -import renderIconVNodes from './render/renderIconVNodes'; +import renderIconNodes from './render/renderIconNodes'; import generateIconFiles from './build/generateIconFiles'; import generateExportsFile from './build/generateExportsFile'; @@ -17,7 +17,7 @@ const svgFiles = fs.readdirSync(IN_DIR).filter(file => path.extname(file) === '. const getSvg = svgFile => fs.readFileSync(path.join(IN_DIR, svgFile)); const icons = renderIconsObject(svgFiles, getSvg); -const iconVNodes = renderIconVNodes(icons); +const iconVNodes = renderIconNodes(icons); generateIconFiles(iconVNodes, OUTPUT_DIR); diff --git a/scripts/render/renderIconVNodes.js b/scripts/render/renderIconNodes.js similarity index 87% rename from scripts/render/renderIconVNodes.js rename to scripts/render/renderIconNodes.js index 60ab4cf34..0f2214764 100644 --- a/scripts/render/renderIconVNodes.js +++ b/scripts/render/renderIconNodes.js @@ -2,7 +2,7 @@ import DEFAULT_ATTRS from './default-attrs.json'; import { parseDOM } from 'htmlparser2'; export default (iconsObject) => { - const iconVnodes = {} + const iconNodes = {} for(const icon in iconsObject) { @@ -18,7 +18,7 @@ export default (iconsObject) => { ])), ]; - iconVnodes[icon] = [ + iconNodes[icon] = [ 'svg', { ...DEFAULT_ATTRS, @@ -27,6 +27,6 @@ export default (iconsObject) => { ] } - return iconVnodes; + return iconNodes; } diff --git a/src/getters/getElement.js b/src/getters/getElement.js index 65c58e5b3..61cba2aaa 100644 --- a/src/getters/getElement.js +++ b/src/getters/getElement.js @@ -14,4 +14,4 @@ const createElement = (tag, attrs, children = []) => { } } -export default (iconVnode) => createElement(iconVnode); +export default (iconNode) => createElement(iconNode);