From d4cbe899fb15c0aeff479ed9a4270cfb60ee637a Mon Sep 17 00:00:00 2001 From: Karsa Date: Tue, 16 Jan 2024 16:21:57 +0100 Subject: [PATCH] Remove aliasesSupport flag from rollup.config.mjs (#1794) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove aliasesSupport flag from rollup.config.mjs and add always add aliases * Update rollup.config.mjs * Update rollup.config.mjs * Update rollup.config.mjs * Update rollup.config.mjs --------- Co-authored-by: Rigó József Karsa --- packages/lucide-preact/rollup.config.mjs | 19 ++----------------- packages/lucide-react/rollup.config.mjs | 19 ++----------------- packages/lucide-vue-next/rollup.config.mjs | 20 ++------------------ packages/lucide-vue/rollup.config.mjs | 19 ++----------------- 4 files changed, 8 insertions(+), 69 deletions(-) diff --git a/packages/lucide-preact/rollup.config.mjs b/packages/lucide-preact/rollup.config.mjs index 9d82bbbfa..64c9876b6 100644 --- a/packages/lucide-preact/rollup.config.mjs +++ b/packages/lucide-preact/rollup.config.mjs @@ -22,34 +22,20 @@ const bundles = [ format: 'cjs', inputs, outputDir, - aliasesSupport: true }, { format: 'esm', inputs, outputDir, preserveModules: true, - aliasesSupport: true }, ]; const configs = bundles - .map(({ inputs, outputDir, format, minify, preserveModules, aliasesSupport }) => + .map(({ inputs, outputDir, format, minify, preserveModules }) => inputs.map(input => ({ input, - plugins: [ - ...( - !aliasesSupport ? [ - replace({ - "export * from './aliases';": '', - "export * as icons from './icons';": '', - delimiters: ['', ''], - preventAssignment: false, - }), - ] : [] - ), - ...plugins(pkg, minify) - ], + plugins: plugins(pkg, minify), external: ['preact'], output: { name: packageName, @@ -81,4 +67,3 @@ const configs = bundles }, ...configs ]; - diff --git a/packages/lucide-react/rollup.config.mjs b/packages/lucide-react/rollup.config.mjs index 80ce8ca7b..e4a153f13 100644 --- a/packages/lucide-react/rollup.config.mjs +++ b/packages/lucide-react/rollup.config.mjs @@ -25,7 +25,6 @@ const bundles = [ format: 'cjs', inputs, outputDir, - aliasesSupport: true, }, { format: 'esm', @@ -35,13 +34,11 @@ const bundles = [ ], outputDir, preserveModules: true, - aliasesSupport: true, }, { format: 'esm', inputs: ['src/dynamicIconImports.ts'], outputFile: 'dynamicIconImports.js', - aliasesSupport: true, external: [/src/], paths: (id) => { if (id.match(/src/)) { @@ -54,22 +51,10 @@ const bundles = [ ]; const configs = bundles - .map(({ inputs, outputDir, outputFile, format, minify, preserveModules, aliasesSupport, entryFileNames, external = [], paths }) => + .map(({ inputs, outputDir, outputFile, format, minify, preserveModules, entryFileNames, external = [], paths }) => inputs.map(input => ({ input, - plugins: [ - ...( - !aliasesSupport ? [ - replace({ - "export * from './aliases';": '', - "export * as icons from './icons';": '', - delimiters: ['', ''], - preventAssignment: false, - }), - ] : [] - ), - ...plugins(pkg, minify) - ], + plugins: plugins(pkg, minify), external: [ 'react', 'prop-types', diff --git a/packages/lucide-vue-next/rollup.config.mjs b/packages/lucide-vue-next/rollup.config.mjs index d1b236944..030d2f3b3 100644 --- a/packages/lucide-vue-next/rollup.config.mjs +++ b/packages/lucide-vue-next/rollup.config.mjs @@ -22,35 +22,20 @@ const bundles = [ format: 'cjs', inputs, outputDir, - aliasesSupport: true }, { format: 'esm', inputs, outputDir, preserveModules: true, - aliasesSupport: true }, ]; const configs = bundles - .map(({ inputs, outputDir, format, minify, preserveModules, aliasesSupport }) => + .map(({ inputs, outputDir, format, minify, preserveModules }) => inputs.map(input => ({ input, - plugins: [ - // This for aliases, only for esm - ...( - !aliasesSupport ? [ - replace({ - "export * from './aliases';": '', - "export * as icons from './icons';": '', - delimiters: ['', ''], - preventAssignment: false, - }), - ] : [] - ), - ...plugins(pkg, minify) - ], + plugins: plugins(pkg, minify), external: ['vue'], output: { name: packageName, @@ -88,4 +73,3 @@ const configs = bundles }, ...configs ]; - diff --git a/packages/lucide-vue/rollup.config.mjs b/packages/lucide-vue/rollup.config.mjs index 16f8e2eb7..911bacfe3 100644 --- a/packages/lucide-vue/rollup.config.mjs +++ b/packages/lucide-vue/rollup.config.mjs @@ -21,35 +21,20 @@ const bundles = [ format: 'cjs', inputs, outputDir, - aliasesSupport: true }, { format: 'esm', inputs, outputDir, preserveModules: true, - aliasesSupport: true }, ]; const configs = bundles - .map(({ inputs, outputDir, format, minify, preserveModules, aliasesSupport }) => + .map(({ inputs, outputDir, format, minify, preserveModules }) => inputs.map(input => ({ input, - plugins: [ - // This for aliases, only for esm - ...( - !aliasesSupport ? [ - replace({ - "export * from './aliases';": '', - "export * as icons from './icons';": '', - delimiters: ['', ''], - preventAssignment: false, - }), - ] : [] - ), - ...plugins(pkg, minify) - ], + plugins: plugins(pkg, minify), external: ['vue'], output: { name: packageName,