diff --git a/packages/lucide-react-native/rollup.config.mjs b/packages/lucide-react-native/rollup.config.mjs index 2d81d1c14..6e53af8ca 100644 --- a/packages/lucide-react-native/rollup.config.mjs +++ b/packages/lucide-react-native/rollup.config.mjs @@ -37,9 +37,16 @@ const bundles = [ const typesModuleMatcher = /[/\\]src[/\\]types\.(d\.)?ts$/; +// With `preserveModules`, every output module would get its own license banner, which +// repeats it ~2,000 times in consumer bundles (#3744). Every icon, and any direct use of +// the `Icon` component, imports `Icon`, so keeping the banner only there includes it +// exactly once in any bundle that renders an icon. +const licenseModuleMatcher = /[/\\]src[/\\]Icon\.ts$/; +const isNotLicenseChunk = (chunk) => !licenseModuleMatcher.test(chunk.facadeModuleId ?? ''); + const configs = bundles.map(({ inputs, outputDir, format, preserveModules, extension = 'js' }) => ({ input: inputs, - plugins: plugins({ pkg }), + plugins: plugins({ pkg, licenseBannerExclude: isNotLicenseChunk }), external: ['react', 'react-native-svg'], output: { name: packageName, diff --git a/tools/rollup-plugins/plugins.js b/tools/rollup-plugins/plugins.js index d150355a7..34da25dec 100644 --- a/tools/rollup-plugins/plugins.js +++ b/tools/rollup-plugins/plugins.js @@ -5,12 +5,33 @@ import esbuild from 'rollup-plugin-esbuild'; import { nodeResolve } from '@rollup/plugin-node-resolve'; import summary from 'rollup-plugin-summary'; +/** + * Wraps a plugin's `renderChunk` hook so it is skipped for chunks matching `exclude`. + * Used to keep the license banner to a single chunk that every consumer path imports, + * instead of repeating it in every module emitted with `preserveModules`. + */ +const skipRenderChunk = (plugin, exclude) => { + if (!exclude) return plugin; + + const { renderChunk } = plugin; + + return { + ...plugin, + renderChunk(code, chunk, ...rest) { + if (exclude(chunk)) return null; + + return renderChunk.call(this, code, chunk, ...rest); + }, + }; +}; + const plugins = ({ pkg, minify = false, withEsbuild = true, esbuildOptions = {}, withSummary = false, + licenseBannerExclude, }) => [ withEsbuild @@ -23,12 +44,15 @@ const plugins = ({ extensions: ['.js', '.ts', '.jsx', '.tsx'], resolveOnly: [/^@lucide\/.*$/], }), - license({ - banner: `@license ${pkg.name} v${pkg.version} - ${pkg.license} + skipRenderChunk( + license({ + banner: `@license ${pkg.name} v${pkg.version} - ${pkg.license} This source code is licensed under the ${pkg.license} license. See the LICENSE file in the root directory of this source tree.`, - }), + }), + licenseBannerExclude, + ), withSummary ? summary() : null, visualizer({ sourcemap: true,