From 5ff536e1391335e4f7dc38d244c1bc458b9443e2 Mon Sep 17 00:00:00 2001 From: Eric Fennis Date: Tue, 16 Jun 2026 16:24:07 +0200 Subject: [PATCH] ci(release.yml): Fix workflow and remove `version` scripts in package scripts (#4479) * ci(release.yml): Remove new-version in release flow * Remove version in scripts * Update workflow --- .github/workflows/release.yml | 4 ++-- packages/angular/package.json | 3 +-- packages/astro/package.json | 3 +-- packages/icons/package.json | 3 +-- packages/lucide-preact/package.json | 3 +-- packages/lucide-react-native/package.json | 3 +-- packages/lucide-react/package.json | 3 +-- packages/lucide-solid/package.json | 3 +-- packages/lucide-static/package.json | 3 +-- packages/lucide/package.json | 3 +-- packages/svelte/package.json | 3 +-- packages/vue/package.json | 3 +-- 12 files changed, 13 insertions(+), 24 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 375f42a18..9d3ff092f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -74,7 +74,7 @@ jobs: run: pnpm install --frozen-lockfile - name: Set new version - run: pnpm --fail-if-no-match --filter ${{ matrix.package }} version ${{ needs.prepare.outputs.VERSION }} --no-git-tag-version + run: pnpm version ${{ needs.prepare.outputs.VERSION }} --filter ${{ matrix.package }} --fail-if-no-match --no-git-tag-version - name: Build run: pnpm --filter ${{ matrix.package }} build @@ -108,7 +108,7 @@ jobs: run: pnpm install --frozen-lockfile - name: Set new version - run: pnpm --filter lucide-static version ${{ needs.prepare.outputs.VERSION }} --no-git-tag-version + run: pnpm version ${{ needs.prepare.outputs.VERSION }} --filter lucide-static --no-git-tag-version - name: Move Font run: cp -r lucide-font packages/lucide-static/font diff --git a/packages/angular/package.json b/packages/angular/package.json index 43c56fb88..a5e843f86 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -26,8 +26,7 @@ "test": "pnpm build:icons && ng test --no-watch", "test:watch": "ng test", "lint": "npx eslint 'src/**/*.{js,jsx,ts,tsx,html,css,scss}' --quiet --fix", - "e2e": "ng e2e", - "version": "pnpm version --git-tag-version=false" + "e2e": "ng e2e" }, "prettier": { "printWidth": 100, diff --git a/packages/astro/package.json b/packages/astro/package.json index 56129cda1..524c5a6b8 100644 --- a/packages/astro/package.json +++ b/packages/astro/package.json @@ -45,8 +45,7 @@ "copy:license": "cp ../../LICENSE ./LICENSE", "copy:utils": "mkdir -p ./src/utils && for f in hasA11yProp toKebabCase mergeClasses; do cp -f ../../packages/shared/src/utils/$f.ts ./src/utils/; done", "test": "pnpm copy:utils && pnpm build:icons && vitest run", - "test:watch": "pnpm build:icons && vitest run --watch", - "version": "pnpm version --git-tag-version=false" + "test:watch": "pnpm build:icons && vitest run --watch" }, "devDependencies": { "@astrojs/ts-plugin": "^1.10.4", diff --git a/packages/icons/package.json b/packages/icons/package.json index adb71a38f..e1a24def4 100644 --- a/packages/icons/package.json +++ b/packages/icons/package.json @@ -57,8 +57,7 @@ "build:bundle": "rollup -c rollup.config.mjs", "test": "pnpm build:icons && vitest run", "test:watch": "vitest watch", - "test:update": "vitest -u", - "version": "pnpm version --git-tag-version=false" + "test:update": "vitest -u" }, "devDependencies": { "@lucide/build-icons": "workspace:*", diff --git a/packages/lucide-preact/package.json b/packages/lucide-preact/package.json index 071360e10..0c503f446 100644 --- a/packages/lucide-preact/package.json +++ b/packages/lucide-preact/package.json @@ -44,8 +44,7 @@ "build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mts --renderUniqueKey --withAliases --aliasesFileExtension=.ts --iconFileExtension=.ts --exportFileName=index.ts", "build:bundles": "rollup -c ./rollup.config.mjs", "test": "pnpm build:icons && vitest run", - "test:watch": "vitest watch", - "version": "pnpm version --git-tag-version=false" + "test:watch": "vitest watch" }, "devDependencies": { "@lucide/build-icons": "workspace:*", diff --git a/packages/lucide-react-native/package.json b/packages/lucide-react-native/package.json index 980262e46..a36826bf5 100644 --- a/packages/lucide-react-native/package.json +++ b/packages/lucide-react-native/package.json @@ -52,8 +52,7 @@ "build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mts --renderUniqueKey --iconFileExtension=.ts --exportFileName=index.ts --withAliases --aliasesFileExtension=.ts", "build:bundles": "rollup -c ./rollup.config.mjs", "test": "pnpm build:icons && vitest run", - "test:watch": "vitest watch", - "version": "pnpm version --git-tag-version=false" + "test:watch": "vitest watch" }, "devDependencies": { "@lucide/build-icons": "workspace:*", diff --git a/packages/lucide-react/package.json b/packages/lucide-react/package.json index bd6f2f26a..6b9e497ba 100644 --- a/packages/lucide-react/package.json +++ b/packages/lucide-react/package.json @@ -47,8 +47,7 @@ "typecheck": "tsc", "typecheck:watch": "tsc -w", "test": "pnpm build:icons && vitest run", - "test:watch": "vitest watch", - "version": "pnpm version --git-tag-version=false" + "test:watch": "vitest watch" }, "devDependencies": { "@lucide/build-icons": "workspace:*", diff --git a/packages/lucide-solid/package.json b/packages/lucide-solid/package.json index d44af5133..80750ea64 100644 --- a/packages/lucide-solid/package.json +++ b/packages/lucide-solid/package.json @@ -65,8 +65,7 @@ "typecheck": "tsc", "typecheck:watch": "tsc -w", "test": "pnpm build:icons && vitest run", - "test:watch": "vitest watch", - "version": "pnpm version --git-tag-version=false" + "test:watch": "vitest watch" }, "devDependencies": { "@babel/core": "^7.23.9", diff --git a/packages/lucide-static/package.json b/packages/lucide-static/package.json index 4e4a1d821..65665a3ba 100644 --- a/packages/lucide-static/package.json +++ b/packages/lucide-static/package.json @@ -34,8 +34,7 @@ "build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mts --iconFileExtension=.ts --withAliases --aliasNamesOnly --aliasesFileExtension=.ts --exportFileName=index.ts", "build:lib": "node ./scripts/buildLib.mts", "build:bundles": "rollup -c rollup.config.mjs", - "clean": "rm -rf lib && rm -rf build && rm -rf icons && rm -f sprite.svg", - "version": "pnpm version --git-tag-version=false" + "clean": "rm -rf lib && rm -rf build && rm -rf icons && rm -f sprite.svg" }, "devDependencies": { "@lucide/build-icons": "workspace:*", diff --git a/packages/lucide/package.json b/packages/lucide/package.json index 11d983ab8..b49b4850e 100644 --- a/packages/lucide/package.json +++ b/packages/lucide/package.json @@ -39,8 +39,7 @@ "build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mts --iconFileExtension=.ts --withAliases --aliasNamesOnly --aliasesFileExtension=.ts --exportFileName=index.ts", "build:bundle": "rollup -c rollup.config.mjs", "test": "pnpm build:icons && vitest run", - "test:watch": "vitest watch", - "version": "pnpm version --git-tag-version=false" + "test:watch": "vitest watch" }, "devDependencies": { "@lucide/build-icons": "workspace:*", diff --git a/packages/svelte/package.json b/packages/svelte/package.json index 4c9fd3e43..a7d5a774c 100644 --- a/packages/svelte/package.json +++ b/packages/svelte/package.json @@ -55,8 +55,7 @@ "build:license": "node ./scripts/appendBlockComments.mts", "test": "pnpm copy:license && pnpm copy:utils && pnpm build:icons && vitest run", "test:watch": "vitest watch", - "typecheck": "pnpm copy:license && pnpm copy:utils && pnpm build:icons && svelte-check --tsconfig ./tsconfig.json", - "version": "pnpm version --git-tag-version=false" + "typecheck": "pnpm copy:license && pnpm copy:utils && pnpm build:icons && svelte-check --tsconfig ./tsconfig.json" }, "devDependencies": { "@lucide/build-icons": "workspace:*", diff --git a/packages/vue/package.json b/packages/vue/package.json index 7186a66e0..e4069cb22 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -38,8 +38,7 @@ "typecheck": "tsc", "typecheck:watch": "tsc -w", "test": "pnpm build:icons && vitest run", - "test:watch": "vitest watch", - "version": "pnpm version --git-tag-version=false" + "test:watch": "vitest watch" }, "devDependencies": { "@lucide/build-icons": "workspace:*",