From 5d35573d89ce2f64de4ef1b54ed241a02db16193 Mon Sep 17 00:00:00 2001 From: Wojciech Maj Date: Mon, 6 Dec 2021 17:32:13 +0100 Subject: [PATCH] fix: fix generateChangelog crashing on commits with no authors (#452) Sample commit crashing: https://api.github.com/repos/lucide-icons/lucide/commits/3756ab98efd94c8c1f383b23a437eefee9249dfc --- scripts/generateChangelog.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/generateChangelog.js b/scripts/generateChangelog.js index 593c5a54f..4b146283e 100644 --- a/scripts/generateChangelog.js +++ b/scripts/generateChangelog.js @@ -56,6 +56,11 @@ const cliArguments = getArgumentOptions(process.argv.slice(2)); const pullNumber = /(.*)\((#[0-9]*)\)/gm.exec(pr.commit.message); const nameRegex = /^\/?(.+\/)*(.+)\.(.+)$/g.exec(filename); + if (!pr.author) { + // Most likely bot commit + return null; + } + return { filename, name: nameRegex && nameRegex[2] ? nameRegex[2] : null, @@ -66,6 +71,7 @@ const cliArguments = getArgumentOptions(process.argv.slice(2)); status, }; }) + .filter(Boolean) .filter(({ pullNumber }) => !!pullNumber); const changelog = topics.map(({ title, filter, template }) => {