code quality improvements + add boolean in a ctive link helper to check if url is active without displaying link

This commit is contained in:
2026-03-17 02:01:07 -07:00
parent 4f996eb7d2
commit 924734b8a4
5 changed files with 22 additions and 15 deletions

View File

@@ -14,7 +14,7 @@
} }
], ],
"require": { "require": {
"php": ">=8.1", "php": ">=8.2",
"cakephp/cakephp": "^5.0" "cakephp/cakephp": "^5.0"
}, },
"require-dev": { "require-dev": {

View File

@@ -8,3 +8,5 @@ parameters:
bootstrapFiles: bootstrapFiles:
- tests/bootstrap.php - tests/bootstrap.php
treatPhpDocTypesAsCertain: false treatPhpDocTypesAsCertain: false
ignoreErrors:
- identifier: trait.unused

View File

@@ -3,7 +3,7 @@ declare(strict_types=1);
namespace CheeseCake\Controller; namespace CheeseCake\Controller;
use App\Controller\AppController as BaseController; use Cake\Controller\Controller;
class AppController extends BaseController { class AppController extends Controller {
} }

View File

@@ -5,9 +5,12 @@ namespace CheeseCake\View\Helper;
use Cake\Routing\Router; use Cake\Routing\Router;
use Cake\View\Helper; use Cake\View\Helper;
use Cake\View\Helper\HtmlHelper;
/** /**
* ActiveLink helper * ActiveLink helper
*
* @property HtmlHelper $Html
*/ */
class ActiveLinkHelper extends Helper { class ActiveLinkHelper extends Helper {
@@ -42,9 +45,9 @@ class ActiveLinkHelper extends Helper {
if (!array_key_exists('target', $options) || !$currentUrl) { if (!array_key_exists('target', $options) || !$currentUrl) {
return $this->Html->link($title, $url, $options); return $this->Html->link($title, $url, $options);
} }
$target = $options['target']; $target = $options['target'];
$activeClass = $options['activeClass'] ?? $this->getConfig('activeClass'); $activeClass = $options['activeClass'] ?? $this->getConfig('activeClass');
unset($options['target']); unset($options['target']);
unset($options['activeClass']); unset($options['activeClass']);
@@ -113,6 +116,7 @@ class ActiveLinkHelper extends Helper {
/** /**
* @param array $providedOptions * @param array $providedOptions
* @param string $toAdd
* *
* @return string * @return string
*/ */
@@ -125,6 +129,7 @@ class ActiveLinkHelper extends Helper {
* @param string $targetString * @param string $targetString
* @param string $title * @param string $title
* @param array|string|null $url * @param array|string|null $url
* @param string $activeClass
* @param array $options * @param array $options
* *
* @return string * @return string