From 8a396fa8c706de639f9074ac7bc6173191b153ef Mon Sep 17 00:00:00 2001 From: Brandon Shipley Date: Fri, 21 Aug 2026 03:17:22 -0700 Subject: [PATCH 1/2] workflow + compsoer stan fixes --- .gitea/workflows/ci.yaml | 2 +- src/Controller/CartItemsController.php | 13 +++---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/.gitea/workflows/ci.yaml b/.gitea/workflows/ci.yaml index 116c897..0fa63a0 100644 --- a/.gitea/workflows/ci.yaml +++ b/.gitea/workflows/ci.yaml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - php-version: ['8.2', '8.4'] + php-version: ['8.2', '8.5'] # db-type: ['mysql'] db-type: ['sqlite', 'mysql', 'pgsql'] prefer-lowest: [''] diff --git a/src/Controller/CartItemsController.php b/src/Controller/CartItemsController.php index a7a234a..f2cc435 100644 --- a/src/Controller/CartItemsController.php +++ b/src/Controller/CartItemsController.php @@ -87,10 +87,7 @@ class CartItemsController extends AppController { public function edit($id = null) { $this->request->allowMethod(['post', 'put', 'patch']); - $cartItem = $this->CartItems->find() - ->where(['CartItems.id' => $id]) - ->contain(['Carts']) - ->firstOrFail(); + $cartItem = $this->CartItems->get($id, contain: ['Carts']); $this->ShoppingCart->checkIfIsOwnCart($cartItem->cart); @@ -135,13 +132,9 @@ class CartItemsController extends AppController { $this->request->allowMethod(['post', 'delete']); $identity = $this->getRequest()->getAttribute('identity'); -// $cart = $this->viewBuilder()->getVar('cart'); - $cartItem = $this->CartItems->find() - ->where(['CartItems.id' => $id]) - ->contain(['Carts']) - ->firstOrFail(); + $cartItem = $this->CartItems->get($id, contain: ['Carts']); - $this->ShoppingCart->checkIfIsOwnCart($cartItem->cart); + $this->ShoppingCart->checkIfIsOwnCart($cartItem->cart); unset($cartItem->cart); if ($this->CartItems->delete($cartItem)) { From daf6998a8b5722d33d9674115b289388a8c9e987 Mon Sep 17 00:00:00 2001 From: Brandon Shipley Date: Fri, 21 Aug 2026 20:24:16 -0700 Subject: [PATCH 2/2] code style fix --- src/Controller/CartItemsController.php | 4 ++-- src/Model/Enum/CartTypeId.php | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Controller/CartItemsController.php b/src/Controller/CartItemsController.php index f2cc435..29475c8 100644 --- a/src/Controller/CartItemsController.php +++ b/src/Controller/CartItemsController.php @@ -132,9 +132,9 @@ class CartItemsController extends AppController { $this->request->allowMethod(['post', 'delete']); $identity = $this->getRequest()->getAttribute('identity'); - $cartItem = $this->CartItems->get($id, contain: ['Carts']); + $cartItem = $this->CartItems->get($id, contain: ['Carts']); - $this->ShoppingCart->checkIfIsOwnCart($cartItem->cart); + $this->ShoppingCart->checkIfIsOwnCart($cartItem->cart); unset($cartItem->cart); if ($this->CartItems->delete($cartItem)) { diff --git a/src/Model/Enum/CartTypeId.php b/src/Model/Enum/CartTypeId.php index cafe1d9..84e233e 100644 --- a/src/Model/Enum/CartTypeId.php +++ b/src/Model/Enum/CartTypeId.php @@ -18,9 +18,9 @@ enum CartTypeId: int implements EnumLabelInterface */ public function label(): string { return match ($this) { - static::Cart => 'Cart', - static::Wishlist => 'Wishlist', - static::CustomList => 'List' + CartTypeId::Cart => 'Cart', + CartTypeId::Wishlist => 'Wishlist', + CartTypeId::CustomList => 'List' }; } }