hipowered.dev/cake-carts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cs fixes
Some checks failed
CI / testsuite (pgsql, 8.2, ) (push) Successful in 4m40s
Details
CI / testsuite (pgsql, 8.4, ) (push) Successful in 6m38s
Details
CI / testsuite (mysql, 8.2, ) (push) Successful in 13m43s
Details
CI / testsuite (sqlite, 8.2, ) (push) Successful in 3m45s
Details
CI / testsuite (mysql, 8.4, ) (push) Successful in 19m5s
Details
CI / testsuite (sqlite, 8.2, prefer-lowest) (push) Failing after 8m37s
Details
CI / testsuite (sqlite, 8.4, ) (push) Successful in 8m35s
Details
CI / Coding Standard & Static Analysis (push) Successful in 12m3s
Details

Browse Source
This commit is contained in:
Brandon Shipley
2026-02-11 19:27:09 -08:00
parent 013bb2e0a9
commit 534c3ab7dc
2 changed files with 65 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Controller/Component/ShoppingCartComponent.php
View File

@@ -73,6 +73,7 @@ class ShoppingCartComponent extends Component {
} else {
$cartsQ->where(['session_id' => $sessionId]);
}
return $cartsQ->firstOrFail();
}

115
tests/TestCase/Controller/Component/ShoppingCartComponentTest.php
View File

@@ -6,9 +6,6 @@ namespace CakeCarts\Test\TestCase\Controller\Component;
use Cake\Controller\ComponentRegistry;
use Cake\Controller\Controller;
use Cake\Datasource\Exception\RecordNotFoundException;
use Cake\Event\Event;
use Cake\Http\Exception\NotFoundException;
use Cake\Http\Response;
use Cake\Http\ServerRequest;
use Cake\TestSuite\IntegrationTestTrait;
use Cake\TestSuite\TestCase;
@@ -19,20 +16,21 @@ use CakeCarts\Controller\Component\ShoppingCartComponent;
*/
class ShoppingCartComponentTest extends TestCase {
use IntegrationTestTrait;
use IntegrationTestTrait;
protected ShoppingCartComponent $component;
protected Controller $controller;
protected ShoppingCartComponent $component;
/**
protected Controller $controller;
/**
* Fixtures
*
* @var array<string>
*/
protected array $fixtures = [
'plugin.CakeCarts.CartItems',
'plugin.CakeCarts.Carts',
];
protected array $fixtures = [
'plugin.CakeCarts.CartItems',
'plugin.CakeCarts.Carts',
];
/**
* setUp method
@@ -41,11 +39,11 @@ class ShoppingCartComponentTest extends TestCase {
*/
protected function setUp(): void {
parent::setUp();
$request = new ServerRequest();
$this->controller = new Controller($request);
$registry = new ComponentRegistry($this->controller);
$request = new ServerRequest();
$this->controller = new Controller($request);
$registry = new ComponentRegistry($this->controller);
$this->component = new ShoppingCartComponent($registry);
$this->component = new ShoppingCartComponent($registry);
}
/**
@@ -54,71 +52,66 @@ class ShoppingCartComponentTest extends TestCase {
* @return void
*/
protected function tearDown(): void {
unset($this->ShoppingCart);
unset($this->component);
parent::tearDown();
}
/**
/**
* @return void
*/
public function testGetCartForUserById()
{
$this->session([
'CakeCarts.session_id' => 'cli',
]);
$cart = $this->component->getCartForUserById('74d1aa54-92a2-4039-bc10-61e1190c51ea');
$this->assertNotNull($cart);
}
public function testGetCartForUserById() {
$this->session([
'CakeCarts.session_id' => 'cli',
]);
$cart = $this->component->getCartForUserById('74d1aa54-92a2-4039-bc10-61e1190c51ea');
$this->assertNotNull($cart);
}
/**
/**
* @return void
*/
public function testGetCartForUserByIdDoesNotExist()
{
$this->expectException(RecordNotFoundException::class);
$cart = $this->component->getCartForUserById('74d1aa54-92a2-4039-bc10-61e1190c51ec');
}
public function testGetCartForUserByIdDoesNotExist() {
$this->expectException(RecordNotFoundException::class);
$cart = $this->component->getCartForUserById('74d1aa54-92a2-4039-bc10-61e1190c51ec');
}
/**
/**
* @return void
*/
public function testGetUserIdField()
{
$this->assertNotNull($this->component->getUserIdField());
}
public function testGetUserIdField() {
$this->assertNotNull($this->component->getUserIdField());
}
/**
/**
* @return void
*/
public function testGetSessionId()
{
$this->assertNotNull($this->component->getSessionId());
}
public function testGetSessionId() {
$this->assertNotNull($this->component->getSessionId());
}
/**
/**
* @return void
*/
public function testCheckIfIsOwnCartIsOwnCart()
{
$this->session([
'CakeCarts.session_id' => 'session_1',
]);
$cart = $this->fetchTable('Carts')->get('74d1aa54-92a2-4039-bc10-61e1190c51ea');
$this->component->checkIfIsOwnCart($cart);
// if exception not thrown test passes
$this->assertEquals(1, 1);
}
public function testCheckIfIsOwnCartIsOwnCart() {
$this->session([
'CakeCarts.session_id' => 'session_1',
]);
$cart = $this->fetchTable('Carts')->get('74d1aa54-92a2-4039-bc10-61e1190c51ea');
$this->component->checkIfIsOwnCart($cart);
// if exception not thrown test passes
$this->assertEquals(1, 1);
}
/**
/**
* @return void
*/
public function testCheckIfIsOwnCartIsNotOwnCart()
{
$this->expectExceptionCode(404);
$cart = $this->fetchTable('Carts')->get('74d1aa54-92a2-4039-bc10-61e1190c51ec');
$this->component->checkIfIsOwnCart($cart);
// if exception not thrown test fails
$this->expectException(RecordNotFoundException::class);
}
public function testCheckIfIsOwnCartIsNotOwnCart() {
$this->expectExceptionCode(404);
$cart = $this->fetchTable('Carts')->get('74d1aa54-92a2-4039-bc10-61e1190c51ec');
$this->component->checkIfIsOwnCart($cart);
// if exception not thrown test fails
$this->expectException(RecordNotFoundException::class);
}
}