cs fixes
Some checks failed
CI / testsuite (pgsql, 8.2, ) (push) Successful in 4m40s
CI / testsuite (pgsql, 8.4, ) (push) Successful in 6m38s
CI / testsuite (mysql, 8.2, ) (push) Successful in 13m43s
CI / testsuite (sqlite, 8.2, ) (push) Successful in 3m45s
CI / testsuite (mysql, 8.4, ) (push) Successful in 19m5s
CI / testsuite (sqlite, 8.2, prefer-lowest) (push) Failing after 8m37s
CI / testsuite (sqlite, 8.4, ) (push) Successful in 8m35s
CI / Coding Standard & Static Analysis (push) Successful in 12m3s

This commit is contained in:
2026-02-11 19:27:09 -08:00
parent 013bb2e0a9
commit 534c3ab7dc
2 changed files with 65 additions and 71 deletions

View File

@@ -73,6 +73,7 @@ class ShoppingCartComponent extends Component {
} else {
$cartsQ->where(['session_id' => $sessionId]);
}
return $cartsQ->firstOrFail();
}

View File

@@ -6,9 +6,6 @@ namespace CakeCarts\Test\TestCase\Controller\Component;
use Cake\Controller\ComponentRegistry;
use Cake\Controller\Controller;
use Cake\Datasource\Exception\RecordNotFoundException;
use Cake\Event\Event;
use Cake\Http\Exception\NotFoundException;
use Cake\Http\Response;
use Cake\Http\ServerRequest;
use Cake\TestSuite\IntegrationTestTrait;
use Cake\TestSuite\TestCase;
@@ -22,6 +19,7 @@ class ShoppingCartComponentTest extends TestCase {
use IntegrationTestTrait;
protected ShoppingCartComponent $component;
protected Controller $controller;
/**
@@ -54,7 +52,7 @@ class ShoppingCartComponentTest extends TestCase {
* @return void
*/
protected function tearDown(): void {
unset($this->ShoppingCart);
unset($this->component);
parent::tearDown();
}
@@ -62,8 +60,7 @@ class ShoppingCartComponentTest extends TestCase {
/**
* @return void
*/
public function testGetCartForUserById()
{
public function testGetCartForUserById() {
$this->session([
'CakeCarts.session_id' => 'cli',
]);
@@ -74,8 +71,7 @@ class ShoppingCartComponentTest extends TestCase {
/**
* @return void
*/
public function testGetCartForUserByIdDoesNotExist()
{
public function testGetCartForUserByIdDoesNotExist() {
$this->expectException(RecordNotFoundException::class);
$cart = $this->component->getCartForUserById('74d1aa54-92a2-4039-bc10-61e1190c51ec');
}
@@ -83,24 +79,21 @@ class ShoppingCartComponentTest extends TestCase {
/**
* @return void
*/
public function testGetUserIdField()
{
public function testGetUserIdField() {
$this->assertNotNull($this->component->getUserIdField());
}
/**
* @return void
*/
public function testGetSessionId()
{
public function testGetSessionId() {
$this->assertNotNull($this->component->getSessionId());
}
/**
* @return void
*/
public function testCheckIfIsOwnCartIsOwnCart()
{
public function testCheckIfIsOwnCartIsOwnCart() {
$this->session([
'CakeCarts.session_id' => 'session_1',
]);
@@ -113,12 +106,12 @@ class ShoppingCartComponentTest extends TestCase {
/**
* @return void
*/
public function testCheckIfIsOwnCartIsNotOwnCart()
{
public function testCheckIfIsOwnCartIsNotOwnCart() {
$this->expectExceptionCode(404);
$cart = $this->fetchTable('Carts')->get('74d1aa54-92a2-4039-bc10-61e1190c51ec');
$this->component->checkIfIsOwnCart($cart);
// if exception not thrown test fails
$this->expectException(RecordNotFoundException::class);
}
}