test fixes shopping cart component
Some checks failed
CI / testsuite (mysql, 8.2, ) (push) Successful in 4m18s
CI / testsuite (pgsql, 8.4, ) (push) Successful in 7m8s
CI / testsuite (sqlite, 8.2, ) (push) Successful in 3m21s
CI / testsuite (pgsql, 8.2, ) (push) Successful in 13m24s
CI / testsuite (sqlite, 8.2, prefer-lowest) (push) Failing after 3m45s
CI / testsuite (mysql, 8.4, ) (push) Successful in 19m22s
CI / Coding Standard & Static Analysis (push) Failing after 2m57s
CI / testsuite (sqlite, 8.4, ) (push) Successful in 15m45s

This commit is contained in:
2026-01-23 22:40:45 -08:00
parent c6d3550272
commit 2be8341cf9
4 changed files with 90 additions and 12 deletions

View File

@@ -73,7 +73,6 @@ class ShoppingCartComponent extends Component {
} else { } else {
$cartsQ->where(['session_id' => $sessionId]); $cartsQ->where(['session_id' => $sessionId]);
} }
return $cartsQ->firstOrFail(); return $cartsQ->firstOrFail();
} }

View File

@@ -22,7 +22,7 @@ class CartsFixture extends TestFixture {
[ [
'id' => '74d1aa54-92a2-4039-bc10-61e1190c51ea', 'id' => '74d1aa54-92a2-4039-bc10-61e1190c51ea',
'cart_type_id' => CartTypeId::Cart->value, 'cart_type_id' => CartTypeId::Cart->value,
'session_id' => 'session_1', 'session_id' => 'cli',
'user_id' => null, 'user_id' => null,
'user_id_uuid' => '5a34a6ae-7d3f-4dcf-bac7-57335b51e697', 'user_id_uuid' => '5a34a6ae-7d3f-4dcf-bac7-57335b51e697',
'created' => '2025-10-08 09:55:15', 'created' => '2025-10-08 09:55:15',
@@ -36,7 +36,7 @@ class CartsFixture extends TestFixture {
[ [
'id' => '74d1aa54-92a2-4039-bc10-61e1190c51eb', 'id' => '74d1aa54-92a2-4039-bc10-61e1190c51eb',
'cart_type_id' => CartTypeId::Cart->value, 'cart_type_id' => CartTypeId::Cart->value,
'session_id' => 'session_1', 'session_id' => 'cli',
'user_id' => null, 'user_id' => null,
'user_id_uuid' => '5a34a6ae-7d3f-4dcf-bac7-57335b51e697', 'user_id_uuid' => '5a34a6ae-7d3f-4dcf-bac7-57335b51e697',
'created' => '2025-10-08 09:55:15', 'created' => '2025-10-08 09:55:15',

View File

@@ -91,7 +91,6 @@ class CartItemsControllerTest extends TestCase {
]; ];
$this->session(['Auth.User.id' => 1]); $this->session(['Auth.User.id' => 1]);
$this->session(['Auth.id' => 1]); $this->session(['Auth.id' => 1]);
$this->session(['CakeCarts.session_id' => 'session_1']);
$before = $this->CartItems->get($id, contain: ['Carts']); $before = $this->CartItems->get($id, contain: ['Carts']);
// dd($before); // dd($before);
$skuId = '3a477e3e-7977-4813-81f6-f85949613979'; $skuId = '3a477e3e-7977-4813-81f6-f85949613979';

View File

@@ -4,6 +4,13 @@ declare(strict_types=1);
namespace CakeCarts\Test\TestCase\Controller\Component; namespace CakeCarts\Test\TestCase\Controller\Component;
use Cake\Controller\ComponentRegistry; use Cake\Controller\ComponentRegistry;
use Cake\Controller\Controller;
use Cake\Datasource\Exception\RecordNotFoundException;
use Cake\Event\Event;
use Cake\Http\Exception\NotFoundException;
use Cake\Http\Response;
use Cake\Http\ServerRequest;
use Cake\TestSuite\IntegrationTestTrait;
use Cake\TestSuite\TestCase; use Cake\TestSuite\TestCase;
use CakeCarts\Controller\Component\ShoppingCartComponent; use CakeCarts\Controller\Component\ShoppingCartComponent;
@@ -12,13 +19,21 @@ use CakeCarts\Controller\Component\ShoppingCartComponent;
*/ */
class ShoppingCartComponentTest extends TestCase { class ShoppingCartComponentTest extends TestCase {
/** use IntegrationTestTrait;
* Test subject
protected ShoppingCartComponent $component;
protected Controller $controller;
/**
* Fixtures
* *
* @var \CakeCarts\Controller\Component\ShoppingCartComponent * @var array<string>
*/ */
protected $ShoppingCart; protected array $fixtures = [
'plugin.CakeCarts.CartItems',
'plugin.CakeCarts.Carts',
];
/** /**
* setUp method * setUp method
* *
@@ -26,8 +41,11 @@ class ShoppingCartComponentTest extends TestCase {
*/ */
protected function setUp(): void { protected function setUp(): void {
parent::setUp(); parent::setUp();
$registry = new ComponentRegistry(); $request = new ServerRequest();
$this->ShoppingCart = new ShoppingCartComponent($registry); $this->controller = new Controller($request);
$registry = new ComponentRegistry($this->controller);
$this->component = new ShoppingCartComponent($registry);
} }
/** /**
@@ -40,5 +58,67 @@ class ShoppingCartComponentTest extends TestCase {
parent::tearDown(); parent::tearDown();
} }
/**
* @return void
*/
public function testGetCartForUserById()
{
$this->session([
'CakeCarts.session_id' => 'cli',
]);
$cart = $this->component->getCartForUserById('74d1aa54-92a2-4039-bc10-61e1190c51ea');
$this->assertNotNull($cart);
}
/**
* @return void
*/
public function testGetCartForUserByIdDoesNotExist()
{
$this->expectException(RecordNotFoundException::class);
$cart = $this->component->getCartForUserById('74d1aa54-92a2-4039-bc10-61e1190c51ec');
}
/**
* @return void
*/
public function testGetUserIdField()
{
$this->assertNotNull($this->component->getUserIdField());
}
/**
* @return void
*/
public function testGetSessionId()
{
$this->assertNotNull($this->component->getSessionId());
}
/**
* @return void
*/
public function testCheckIfIsOwnCartIsOwnCart()
{
$this->session([
'CakeCarts.session_id' => 'session_1',
]);
$cart = $this->fetchTable('Carts')->get('74d1aa54-92a2-4039-bc10-61e1190c51ea');
$this->component->checkIfIsOwnCart($cart);
// if exception not thrown test passes
$this->assertEquals(1, 1);
}
/**
* @return void
*/
public function testCheckIfIsOwnCartIsNotOwnCart()
{
$this->expectExceptionCode(404);
$cart = $this->fetchTable('Carts')->get('74d1aa54-92a2-4039-bc10-61e1190c51ec');
$this->component->checkIfIsOwnCart($cart);
// if exception not thrown test fails
$this->expectException(RecordNotFoundException::class);
}
} }